chore: client library inheritance fixes and simplifications#282
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Jan 13, 2025
Merged
chore: client library inheritance fixes and simplifications#282allenporter merged 1 commit intoPython-roborock:mainfrom
allenporter merged 1 commit intoPython-roborock:mainfrom
Conversation
Collaborator
|
commitlint gets mad if the subject is capatilized, idk why.I've just never changed it. Semantic release I don't believe requires that to be the case |
3924dd4 to
c72a31c
Compare
Lash-L
approved these changes
Jan 13, 2025
Collaborator
Lash-L
left a comment
There was a problem hiding this comment.
Looks good, a good bit of redundant code removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the base classes to use the
abcpackage, which provides the infrastructure for defining abstract base classes. Remove variables that are overridden in multiple places so that variables are only set once in the class hierarchy. The fixes include:@abstractmethodto avoid needing theraise NotImplementedreducing untested lines of code_endpointonly once, rather than multiple times. Removed the places where it is not used. (Question: Local commands use it when secured with "abc" but does it do anything?)_loggeronce for each client in the client itself so that the log messages are associated with the actual client being used. This will let us tell the difference between a local client disconnecting and a cloud client disconnecting which is difficult to do today_send_msg_rawin both the v1 mqtt client and the base mqtt clientIssue #228