Conversation
|
@allenporter The pytest are failing here? |
|
I re-ran it and it massed. I can't tell if there is a race or it actually took 4 seconds to do the handoff between threads, or if it is flaky for another reason. I may need to turn on debug on the CI to track it down. Are those windows nodes typically slow? |
I think it is hitting the timeout. I saw windows flake on another PR's run and it took over two minutes. What's the background for why this runs on windows? does it need to? |
Background was just extra testing to make super we didn't have anything platform specific. Probably not needed |
OK, i will remove then if that is OK. FWIW I have yet to ever have any windows (or mac compatibility) issues with python, so it should be pretty safe, but we can revisit of course if there is ever a regression on a specific platform. |
allenporter
left a comment
There was a problem hiding this comment.
Sorry forgot to approve this. I'm fine to adjust to the style, but also appreciate it.
This should allow caps and get us past the commitlint breaking change.
Doing this as a fix to alos check and see if semantic release is working on this new repo