chore: remove one level of local client inheritence#285
Merged
humbertogontijo merged 1 commit intoPython-roborock:mainfrom Jan 13, 2025
Merged
chore: remove one level of local client inheritence#285humbertogontijo merged 1 commit intoPython-roborock:mainfrom
humbertogontijo merged 1 commit intoPython-roborock:mainfrom
Conversation
humbertogontijo
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove one level of local client inheritence by pulling out
asyncio.Protocolinto a separate class. This is a fairly small change, but makes it clear which methods are public parts of the class that callers can invoke vs which can are internal callbacks used by the transport.