chore: remove level of inheritance in mqtt client#286
Merged
humbertogontijo merged 1 commit intoPython-roborock:mainfrom Jan 13, 2025
Merged
chore: remove level of inheritance in mqtt client#286humbertogontijo merged 1 commit intoPython-roborock:mainfrom
humbertogontijo merged 1 commit intoPython-roborock:mainfrom
Conversation
humbertogontijo
approved these changes
Jan 13, 2025
Collaborator
humbertogontijo
left a comment
humbertogontijo
left a comment
There was a problem hiding this comment.
I think this was a nice touch. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull the overrides related to the MQTT client library into a separate class, to avoid a level of inheritance. This makes it more clear which methods are part of the interaction with the MQTT client vs which are part of other base classes. It also makes it clear which overrides are MQTT client library specific vs part of the other parent classes.
Issue #228