fix: set unique sequence numbers on outgoing messages#300
Merged
allenporter merged 1 commit intoPython-roborock:mainfrom Jan 21, 2025
Merged
fix: set unique sequence numbers on outgoing messages#300allenporter merged 1 commit intoPython-roborock:mainfrom
allenporter merged 1 commit intoPython-roborock:mainfrom
Conversation
Lash-L
previously approved these changes
Jan 21, 2025
Contributor
Author
|
I think this fix may explain most of the issues we're seeing like home-assistant/core#129582 or the invalidate state id since its assigning the same number to all requests. |
allenporter
force-pushed
the
wait-queue
branch
from
847e6b3 to
c3f3f81
Compare
Lash-L
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the message constructors to use a factory rather than a fixed constant. The bug is that the function is called only once, rather than on every construction. Add a test to verify that the messages are initialized with unique values.
Issue #228
Issue #222