refactor: breaking change to remove sync APIs#306
Merged
humbertogontijo merged 4 commits intoPython-roborock:mainfrom Jan 23, 2025
Merged
refactor: breaking change to remove sync APIs#306humbertogontijo merged 4 commits intoPython-roborock:mainfrom
humbertogontijo merged 4 commits intoPython-roborock:mainfrom
Conversation
humbertogontijo
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two breaking changes:
sync_version to the fullyasync_version. These APIs currenty log warnings when not called from an async when an event loop is not started.__del__method which is not async. This is logged at debug since i'm not sure how reliable it is to check "is_connected"Issue #228