fix: don't wait for the mqtt thread to fully shutdown when disconecting.#309
Closed
allenporter wants to merge 1 commit intoPython-roborock:mainfrom
Closed
fix: don't wait for the mqtt thread to fully shutdown when disconecting.#309allenporter wants to merge 1 commit intoPython-roborock:mainfrom
allenporter wants to merge 1 commit intoPython-roborock:mainfrom
Conversation
Lash-L
approved these changes
Jan 26, 2025
allenporter
force-pushed
the
test-speed
branch
from
4c65ac2 to
a8d4783
Compare
Contributor
Author
|
This also had a flaky test. Looking at the test timeout, it shows a bunch of threads still running, so this change has the desired effect, but i think it leaves the threads stacked up at the end. Maybe it's too resource intensive to do this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation is because this speeds up the tests to not have to wait for all threads to fully shut down. This can take a moment since it does a join of the thread.