add scenes/routines support#317
Conversation
|
Hi @regevbr - thanks for the PR! We are trying to be better about adding tests into this library. Would you mind including a test in the tests_web_api that tests getting routines correctly? You can see how it is done for the other methods in this file |
|
As well, please run pre-commit run --all-files on your branch and fix any linting issues. You can ignore the lint commit message, as we will make sure it is correct when we merge this in. |
|
@Lash-L done |
|
Added one last fix. I went over the HA code and after this update we can create button entities for each scene for each device |
|
I went ahead and merged in dev for you - I left a few comments, do you mind trying to resolve them? Other than that this will be good for me and I am happy to get included. Were you planning to do a follow up PR to add the ability into HA? If so - Core or custom? |
Automatically generated by python-semantic-release
Resolved. |
|
HA PR is already WIP home-assistant/core#137203 |
|
Thanks @regevbr ! |
Solves #102
Thanks to @muinmomin as posted in humbertogontijo/homeassistant-roborock#169 (comment) I was able to add scene/routine functionality.
Once this will get released, we can add it to HA, as requested in humbertogontijo/homeassistant-roborock#169 and humbertogontijo/homeassistant-roborock#419