fix: Reduce log level of decode errors#691
Merged
allenporter merged 6 commits intoPython-roborock:mainfrom Dec 22, 2025
Merged
Conversation
We need to resolve the source of decode errors, however we shouldn't spam the logs since they may not be actionable for users. We should instead focus on fixing symptoms like things broken like RPCs that don't contain a response (e.g. timeouts)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the log level for message decode failures from warning to debug in the decoder_callback function. The change aims to reduce log spam for decode errors that may not be actionable for users, as explained in the PR description and linked issue.
- Changed logging level from
logger.warning()tologger.debug()for failed message decoding
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
We need to resolve the source of decode errors, however we shouldn't spam the logs since they may not be actionable for users. We should instead focus on fixing symptoms like things broken like RPCs that don't contain a response (e.g. timeouts)
allenporter
force-pushed
the
decode-warning
branch
from
4c41232 to
958f945
Compare
Lash-L
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to resolve the source of decode errors, however we shouldn't spam the logs since they may not be actionable for users. We should instead focus on fixing symptoms like things broken like RPCs that don't contain a response (e.g. timeouts)
home-assistant/core#159334