Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the RoborockFinishReason enum from RoborockEnum to RoborockModeEnum to better handle duplicate finish reason codes, and adds two new finish reason codes (78 and 79) for pet furniture detection features.
Changes:
- Converted
RoborockFinishReasonto useRoborockModeEnumwith tuple-based values (name, code) - Added
CHECK_SAVED_PET_FURNITURES(code 78) andGET_SAVED_PET_FURNITURES(code 79) finish reasons - Updated tests to access the finish reason code via the
.codeattribute
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roborock/data/v1/v1_code_mappings.py | Migrated RoborockFinishReason from RoborockEnum to RoborockModeEnum, added two new finish reason codes (78, 79), and fixed a typo in FINISHED_CLEANING_5 |
| tests/devices/traits/v1/test_clean_summary.py | Updated test assertions to check finish_reason.code instead of direct value comparison |
| tests/data/v1/test_v1_containers.py | Updated test assertions to check finish_reason.code instead of direct value comparison |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #523