Add padding to cshuffle epilogue to avoid bank conflict#3671
Closed
ThomasNing wants to merge 6 commits intodevelopfrom
Closed
Add padding to cshuffle epilogue to avoid bank conflict#3671ThomasNing wants to merge 6 commits intodevelopfrom
ThomasNing wants to merge 6 commits intodevelopfrom
Conversation
Contributor
Author
|
@tenpercent For your reference~ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds padding to the CShuffleEpilogue to avoid bank conflicts on AMD GPUs, specifically targeting 64-way bank conflicts. The changes synchronize the implementation with an internal repository and modify the LDS (Local Data Store) block descriptor generation logic.
Changes:
- Added conditional padding logic for GFX950 architecture to avoid bank conflicts
- Implemented multi-layer LDS block descriptor transformations for both RowMajor and ColumnMajor layouts
- Changed tile distribution pattern from
thread_rakedtowarp_raked
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7 tasks
Contributor
|
Imported to ROCm/rocm-libraries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added the padding to CShuffle Epilogue to avoid the bank conflicts of 64. Synced up and learned from the internal repo.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered