[CK-Tile] Improve cshuffle epilogue mfma tile coverage#3701
Closed
tenpercent wants to merge 1 commit intodevelopfrom
Closed
[CK-Tile] Improve cshuffle epilogue mfma tile coverage#3701tenpercent wants to merge 1 commit intodevelopfrom
tenpercent wants to merge 1 commit intodevelopfrom
Conversation
tenpercent
requested review from
Snektron,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
shumway,
vidyasagar-amd and
vpietila-amd
as code owners
tenpercent
force-pushed
the
cshuffle-epilogue-tests
branch
2 times, most recently
from
9cb1525 to
610fdc7
Compare
tenpercent
force-pushed
the
cshuffle-epilogue-tests
branch
from
610fdc7 to
ec9b306
Compare
1 task
tenpercent
force-pushed
the
cshuffle-epilogue-tests
branch
from
ec9b306 to
ca46fb3
Compare
…and improved verification This commit refactors and expands the CShuffleEpilogue test suite with the following improvements: - Shard tests by data type (FP16, FP8) and add gfx950-specific FP8 tests - Extract scale tests into a separate target for better organization - Implement robust verification using set-based comparison to ensure all expected values are present - Add distribution uniformity checks to verify proper data shuffling - Strengthen verification to require kBlockSize unique values and validate all rows independently - Add support for parameterized test configurations covering various warp layouts and MFMA types - Improve code organization by separating concerns and extracting common utilities - Fix memory leaks and improve code hygiene - Add CMake support for OCP FP8 compilation flag The refactored test suite provides better coverage, more rigorous verification, and improved maintainability for the CShuffleEpilogue functionality. Co-Authored-By: Claude <noreply@anthropic.com>
tenpercent
force-pushed
the
cshuffle-epilogue-tests
branch
from
ca46fb3 to
891efbb
Compare
Contributor
|
Imported to ROCm/rocm-libraries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors and expands the CShuffleEpilogue test suite with comprehensive coverage and improved verification.
Changes
1. Sharded tests by data type with gfx950-specific variants
test_cshuffle_epilogue.cppinto:test_cshuffle_epilogue_fp16.cpp- FP16/BF16 data type teststest_cshuffle_epilogue_fp8.cpp- FP8 data type teststest_cshuffle_epilogue_fp8_gfx950.cpp- gfx950-specific FP8 teststest_cshuffle_epilogue_scale.cpp- Scale tests as a separate targettest_cshuffle_epilogue_common.hppto share common test infrastructure2. Improved verification with robust checks
3. Expanded test coverage with parameterized configurations
4. Code quality improvements
5. CMake support for OCP FP8 compilation flag
test/ck_tile/epilogue/CMakeLists.txtto conditionally add-DCK_TILE_USE_OCP_FP8compile option whenCK_USE_OCP_FP8is enabledTest plan
test_ck_tile_cshuffle_epilogue_fp16,test_ck_tile_cshuffle_epilogue_fp8,test_ck_tile_cshuffle_epilogue_fp8_gfx950,test_ck_tile_cshuffle_epilogue_scale)