Conversation
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Aug 5, 2022
it's a maintainance release, see the announcement: https://godotengine.org/article/maintenance-release-godot-3-4-5 While here regen patches and add links to upstream PRs: - "unbreak OS_Unix::get_executable_path() on OpenBSD" godotengine/godot#61540 - "add OpenBSD support" RenderKit/embree#379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
as per title, this pr fixes some issues found when trying to build bits of embree code vendored in Godot on OpenBSD.
longs because size_t and ssize_t are typedef'd to long and it fails in parallel_partition.h due to an ambiguous call otherwise;argv[0]if you need it.we kept these patches in for building the Godot package for a while (see here and here.)