⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Re-enable rolling build on Windows #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
minggangw merged 2 commits into from
Jan 26, 2026
+2 −1
Merged

Re-enable rolling build on Windows #1382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6862217
Re-enable rolling build on Windows
minggangw Jan 26, 2026
576462a
Add ros2 rolling
minggangw Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/windows-build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
- humble
- jazzy
- kilted
- rolling
steps:
- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v6
Expand All @@ -39,7 +40,7 @@ jobs:
if: ${{ matrix.ros_distribution == 'rolling' }}
shell: bash
run: |
wget --quiet https://ci.ros2.org/view/packaging/job/packaging_windows/lastSuccessfulBuild/artifact/ws/ros2-package-windows-AMD64.zip -O rolling.zip
wget --quiet https://github.com/ros2/ros2/releases/download/release-rolling-nightlies/ros2-rolling-nightly-windows-amd64.zip -O rolling.zip
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title indicates this change is meant to "Re-enable rolling build on Windows", but the 'rolling' distribution is not included in the matrix (lines 18-21 only list humble, jazzy, and kilted). This means the conditional step on line 39 will never execute, and the URL change will have no effect.

To actually enable the rolling build, 'rolling' needs to be added to the ros_distribution matrix. For reference, the Linux x64 workflow (linux-x64-build-and-test.yml) includes 'rolling' in its matrix at line 29.

Copilot uses AI. Check for mistakes.
7z x rolling.zip -y -o/c/dev/rolling

- name: Prebuild - Setup VS Dev Environment
Expand Down
Loading