⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Bring back parallel tool calls #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mrubens wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bring back parallel tool calls #10832

mrubens wants to merge 2 commits into from
+11 −10

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jan 19, 2026 •
edited by ellipsis-dev bot
Loading

Important

Re-enable parallel tool calls by checking the MULTIPLE_NATIVE_TOOL_CALLS experiment in presentAssistantMessage.ts and Task.ts, and update ExperimentalSettings.tsx to display this setting.

  • Behavior:
    • Re-enable parallel tool calls by checking MULTIPLE_NATIVE_TOOL_CALLS experiment in presentAssistantMessage() in presentAssistantMessage.ts and Task class in Task.ts.
  • UI:
    • Remove filter hiding MULTIPLE_NATIVE_TOOL_CALLS in ExperimentalSettings.tsx to display the setting in the UI.

This description was created by Ellipsis for 72fdff7. You can customize this summary. It will automatically update as commits are pushed.

@roomote
Copy link
Contributor

roomote bot commented Jan 19, 2026 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review complete after merge from main. No issues found.

The merge correctly preserved the parallel tool calls experimental feature:

  • MULTIPLE_NATIVE_TOOL_CALLS experiment remains properly defined in src/shared/experiments.ts
  • Experiment flag resolution in Task.ts (lines 3990-4005) correctly passes parallelToolCalls to API metadata
  • UI settings in ExperimentalSettings.tsx continue to display all experiments including this one

The implementation follows existing patterns and is consistent with existing tests.

Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens
Copy link
Collaborator Author

mrubens commented Jan 23, 2026

@roomote please resolve the conflicts against main

@roomote
Copy link
Contributor

roomote bot commented Jan 23, 2026 •
edited
Loading

Fixaroo Clock   See task on Roo Cloud

Resolved merge conflicts against main. All local checks passed.

View commit | Revert commit

@roomote
Merge main into bring_back_parallel_tool_calls
72fdff7 
Resolved conflicts:
- src/core/assistant-message/presentAssistantMessage.ts: Keep new nativeArgs validation and add experiment check
- src/core/task/Task.ts: Keep shouldIncludeTools and use experiment-based parallelToolCallsEnabled
@hannesrudolph hannesrudolph marked this pull request as ready for review January 23, 2026 05:49
@hannesrudolph hannesrudolph requested review from cte and jr as code owners January 23, 2026 05:49
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Enhancement New feature or request labels Jan 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🚀 Preview deployed!

Your changes have been deployed to Vercel:

Preview URL: https://roo-code-website-eofykw4gc-roo-code.vercel.app

This preview will be updated automatically when you push new commits to this PR.

@roomote
Copy link
Contributor

roomote bot commented Jan 23, 2026 •
edited
Loading

Rooviewer Clock   See task on Roo Cloud

Review complete. Found 1 issue to address.

  • Dead code in presentAssistantMessage.ts: The variable isMultipleNativeToolCallsEnabled is declared but never used

The changes in Task.ts correctly enable the parallelToolCalls API metadata flag when the experiment is enabled. However, the corresponding variable in presentAssistantMessage.ts appears to be dead code that should be cleaned up.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

roomote[bot]
roomote bot reviewed Jan 23, 2026
View reviewed changes
src/core/assistant-message/presentAssistantMessage.ts
Comment on lines +488 to +492
// Check experimental setting for multiple native tool calls
const isMultipleNativeToolCallsEnabled = experiments.isEnabled(
state?.experiments ?? {},
EXPERIMENT_IDS.MULTIPLE_NATIVE_TOOL_CALLS,
)
Copy link
Contributor

@roomote roomote bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable isMultipleNativeToolCallsEnabled is declared here but never used anywhere in this function. This appears to be dead code. The parallel tool call behavior is controlled by parallelToolCalls in Task.ts (which is passed to the API metadata), but this variable in presentAssistantMessage.ts doesn't modify any behavior - the didAlreadyUseTool check at line 436 will still reject all but the first tool even when this experiment is enabled. If this variable was intended to control execution of multiple tools, the implementation appears incomplete. Consider removing this dead code.

Fix it with Roo Code or mention @roomote and request a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roomote roomote[bot] roomote[bot] approved these changes

@cte cte Awaiting requested review from cte cte is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Enhancement New feature or request size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Roo Code Roadmap
Status: Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrubens @roomote