⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jan 22, 2026

Summary

Removes the MCP SERVERS section from the system prompt since MCP tools are now included in the native tools array sent with API requests.

Problem

MCP tools were being duplicated in two places:

  1. In the native tools array sent with API requests (via getMcpServerTools())
  2. In the system prompt text (via getMcpServersSection())

This duplication was unnecessary and added extra tokens to the system prompt.

Solution

  • Delete src/core/prompts/sections/mcp-servers.ts
  • Remove getMcpServersSection export from sections/index.ts
  • Remove MCP section from system.ts prompt template
  • Update related tests and snapshots

MCP tools continue to work via the native tools array sent in API requests.

Test Plan

  • All existing tests pass
  • MCP tools still function correctly via native tool array

Resolves COM-550


Important

Removes MCP SERVERS section from system prompt, consolidating MCP tools into the native tools array.

  • Behavior:
    • Removes MCP SERVERS section from system.ts prompt template.
    • Deletes getMcpServersSection from sections/index.ts and mcp-servers.ts.
    • Updates tests in add-custom-instructions.spec.ts to reflect removal.
  • Tests:
    • Removes snapshot mcp-server-creation-enabled.snap and updates others to reflect changes.
    • Ensures MCP tools function via native tool array in API requests.
  • Misc:
    • Resolves COM-550.

This description was created by Ellipsis for 492233b. You can customize this summary. It will automatically update as commits are pushed.

MCP tools are now included in the native tools array sent with API
requests, so the system prompt no longer needs a separate MCP SERVERS
section.

- Delete src/core/prompts/sections/mcp-servers.ts
- Remove getMcpServersSection export from sections/index.ts
- Remove MCP section from system.ts prompt template
- Update related tests and snapshots
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners January 22, 2026 16:20
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 22, 2026
@roomote
Copy link
Contributor

roomote bot commented Jan 22, 2026

Rooviewer Clock   See task on Roo Cloud

Reviewed the changes and found no blocking issues. The PR correctly removes the MCP SERVERS section from the system prompt since MCP tools are now included in the native tools array via getMcpServerTools().

Verified:

  • All tests pass
  • No remaining references to getMcpServersSection in the codebase
  • MCP tools continue to work via the native tools array in build-tools.ts
  • Snapshots correctly updated to reflect the removal

No issues found.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants