Open
Conversation
Author
|
I'm looking for when this was changed in AR. I think I should add an AR version check to my conditional. Thoughts? |
Author
|
I found the commit. |
Author
|
I guess we could use the Rails version >= v5.0.0.beta2. |
Member
|
@atomical Thanks for working on this Looking at the "Coverage decreased" error, I see that your new code isn't being tested. Can you add a test case to the test suite to verify that your code works as expected? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The column :default can be a Proc. This supports the new syntax.
Relevant issues:
#28
SchemaPlus/schema_validations#71