Fix NPE when ModifyExpressionValue uses "CONSTANT" as a target #6
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Su5eD
added a commit
that referenced
this pull request
Feb 3, 2026
Co-authored-by: Alexandra-Myers <[email protected]>
Merged
Su5eD
added a commit
that referenced
this pull request
Feb 3, 2026
* Migrate DynFixSliceBoundary to pipeline * Migrate DynFixAtVariableAssignStore to pipeline * Migrate DynFixParameterTypeAdapter to pipeline * Dynamic property containers * Migrate dynamic fixers to transformation pipeline * New Patch pipeline and transformer itf * Migrate away from MethodContext * Rename definition to core * Transformer pipeline phases * Stable frame analysis * Patch method calls in redirect * Cleanup TODOs * Fix frame analysis failing due to incorrect maxs * Fix plural key application * Injection point resolver for modified params * Handle overloaded injection point targets * Cast replaced inherited parameters to expected type * Remap parsed literal class targets * Parse mixins after running class transformers * Improve overloaded target resolution * Fix LVLookup incorrect parameter ordinals * Fix Shared locals param capture * Use clear target in redirect when possible * Pipeline Auditing * Box types in wrap op calls * Add Combatify test from #6 Co-authored-by: Alexandra-Myers <[email protected]> * Disable this test in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
A
NullPointerExceptionis triggered when Adapter tries to patch aModifyExpressionValuethat uses "CONSTANT" as a target as it fails to find the value fortarget()in the at annotation within the call toMethodContext.getInjectionPointMethodQualifier().The Proposal
As a
ModifyExpressionValue's return value for the mixin method must return the same as its target, rather than using the target's descriptor to get the expected return type, it should be expected to be equivalent to the return type for the mixin method. Therefore, the change is to use the mixin method's descriptor in order to ensure it is never null.Possible Side Effects
If it were somehow the case that the return type did not match the target for the
ModifyExpressionValueit might be possible for this to cause incorrect behaviour, although it seems unlikely.Alternatives
I had considered instead finding some way to account for specifically the types of the target method, however after careful consideration I figured this solution out as it was far simpler and cleaner than checking what type the target returned.