⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@DaviddeBest-TNO
Copy link
Contributor

No description provided.

@DaviddeBest-TNO DaviddeBest-TNO linked an issue Dec 17, 2025 that may be closed by this pull request
@DaviddeBest-TNO DaviddeBest-TNO force-pushed the 759-upgrade-edc-client-to-v3 branch from b77be62 to 61b79cc Compare January 15, 2026 14:07
@DaviddeBest-TNO DaviddeBest-TNO marked this pull request as ready for review January 15, 2026 14:07
@DaviddeBest-TNO
Copy link
Contributor Author

@bnouwt First comment on changes in the Knowledge Directory. We will not be able to avoid sending the EDC participant ID and protocol URL to other KERs through the Knowledge Directory as a KER needs this information to do a catalog request of another participant and it cannot get this information from anywhere else. So the changes in its API input are necessary I would say

Copy link
Collaborator

@bnouwt bnouwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DaviddeBest-TNO, you did a nice job with this pull request.👍

As usual I have been extra picky for the review and this results in quite a few comments, but most are not really mandatory fixes. One thing I do think requires fixing is the fact that users have to manually build the testkd and testsc docker images for the example to run successfully. We either need to add this to the README.md or make sure the docker images are publicly available (which it should after we release the next version of the KE).

As mentioned before, I do not really like the additional KER properties being distributed via the knowledge-directory. I did try to find ways to not having to (see various comments), so I would like to discuss those with you. If we conclude those are not feasible/possible/desirable, then I will accept these additional fields.😢

So, let's discuss this PR further and get it merged!

Regards, Barry

@DaviddeBest-TNO DaviddeBest-TNO force-pushed the 759-upgrade-edc-client-to-v3 branch from b3c7bc1 to a1e6602 Compare February 3, 2026 10:07
Copy link
Collaborator

@bnouwt bnouwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gogogo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade EDC client to v3

3 participants