Persist FAISS index using Docker volume #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avyakt06jain
force-pushed
the
persist-faiss-docker-volume
branch
from
31a9f80 to
7d698cd
Compare
Collaborator
|
LGTM. Please sign your commits. |
Signed-off-by: Avyakt Jain <[email protected]>
avyakt06jain
force-pushed
the
persist-faiss-docker-volume
branch
from
7d698cd to
a6a1db8
Compare
Contributor
Author
|
I have signed my commits. Kindly have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a dedicated Docker volume for the FAISS index so that it persists across backend container restarts.
Changes
Mount a persistent Docker volume to
/ORAssistant-backend/faiss_dbin the backend serviceContext
This change was discussed with @palaniappan-r, who suggested persisting the FAISS index via a separate volume as a useful improvement.
Related issue: #204