Conversation
|
This looks pretty good, it needs a unit test like the other types, and that unit test should be properly gated behind C++17 conditionals like similar features. |
203ba6f to
72c5e26
Compare
72c5e26 to
83cb386
Compare
|
Hi there, sorry for the small delay on this PR lol I have added the required tests, however it's failing for Error message : Which I'm not sure I follow, because obviously I defined both save/load pair and its working fine for the Binary archives, and furthermore I looked at the save/load functions of the However the string type seems to be able to run tests on Json + XML archives without a problem... Could you help me figure out why its not working ? |
|
Also, small note that there was a few compilations errors in files unrelated to mines, but I fixed them regardless (in You might want to double-check theses fixes, just to be sure. Tests are all passing, so I'm assuming its fine. |
Adding
std::filesystem::pathsupport in cereal.Relying on the current
std::stringserialization since it is the underling storage for filesystem::path.