Added support for RTL languages, correct list indentation#202
Open
werksjan wants to merge 3 commits intoUncodin:masterfrom
Open
Added support for RTL languages, correct list indentation#202werksjan wants to merge 3 commits intoUncodin:masterfrom
werksjan wants to merge 3 commits intoUncodin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RTL Languages
I added
to the
BPDisplaySettings, so the system's default (Natural) may be overridden in case the content is known to contain a right-to-left language on a left-to-right device.The setting get's interpreted when styling the paragraphs in the
BPAttributedStringConverterand defaults toNSTextAlignmentNatural, the system default.Correct list indentation
When list items run over more than one line, the broken lines should be indented so they start where the first line starts; after the bullet and the space.
For that to work, instead of inserting tab characters before the list item to match the level, I insert the zero-width character for all levels and apply the correct indentations for the level to the paragraph style.
As the bullet uses a monospace font and (afais) cannot be configured, this should work for any settings.