Replace assert statements #3993
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
assert_almost_equalwithassert_allclosein a few handful of places where it was necessary, primarily intests/interpolate/.rtol=1e-6was used in most places withrtol=1e-7applied. The magnitude and units of the computed quantities indicated that the difference below these levels are not physically meaningful. Decimal inspection sometimes suggestedrtol=1e-12but that is too strict i think and could depend on implementation and hardware hence didn't use it.atolwas not added explicitly wherever the default value of 0 was desirable.Checklist
assert_allclose#3244