⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@tensor-calculus
Copy link

Description

This PR replaces assert_almost_equal with assert_allclose in a few handful of places where it was necessary, primarily in tests/interpolate/. rtol=1e-6 was used in most places with rtol=1e-7 applied. The magnitude and units of the computed quantities indicated that the difference below these levels are not physically meaningful. Decimal inspection sometimes suggested rtol=1e-12 but that is too strict i think and could depend on implementation and hardware hence didn't use it. atol was not added explicitly wherever the default value of 0 was desirable.

Checklist

@tensor-calculus tensor-calculus requested a review from a team as a code owner January 26, 2026 09:57
@tensor-calculus tensor-calculus requested review from dopplershift and removed request for a team January 26, 2026 09:57
@tensor-calculus
Copy link
Author

/examples/remote/basic.py relies on live GOES data, which can cause the docs build to fail depending on when CI runs. I added sphinx_gallery_skip = True to skip executing the example and keep CI stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider assert_allclose

1 participant