Expose disk size for installed plugins #10671
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
Please address the coding standards issues.
| // Check if this is the plugins individual header. | ||
| if ( isset( $field['is_plugins_header'] ) && $field['is_plugins_header'] ) { | ||
| // Format header with tree character. | ||
| $header_label = ' ├─ ' . esc_html( $field['label'] ); |
There was a problem hiding this comment.
I'm not totally sold on this way of formatting the plugins.
| // Format value as "plugin_name: size" if we have a size value. | ||
| if ( ! empty( $values ) && $values !== esc_html( __( 'Loading…' ) ) ) { | ||
| // Extract plugin name from label (remove tree characters and spaces). | ||
| $plugin_name = preg_replace( '/^\s*[├└]─\s*/', '', $field['label'] ); |
There was a problem hiding this comment.
Humm. The tree characters are added and then later removed? It seems like it should be added only at the end when it is printed.
2 participants
https://core.trac.wordpress.org/ticket/64445