Conversation
| bool remote = path.endsWith("remote"); | ||
|
|
||
| QStringList pathElements = path.split('/'); | ||
| QString libraryName = DBHelper::getLibraryName(pathElements.at(2).toInt()); |
There was a problem hiding this comment.
This and the identical change in PageController::service() are the ones I'm not sure about. If the call to DBHelper::getLibraryName() is useful here, either the variable assignment should be removed or an explaining comment should be added.
vedgy
force-pushed
the
fix-some-compiler-warnings
branch
from
d022128 to
1e8db7b
Compare
|
From a first glance, this is a bit of a mixed bag. A good amount of these are no-brainers and can be easily merged but there are some commit thrown in (like the pagecontroller) that need closer examination which I can't provide given that I don't use YACReader for iOS. |
|
I think the only risky commit here is the
I've also ported away from some deprecated Qt API in #206, so you may want to look at it as well. |
vedgy
force-pushed
the
fix-some-compiler-warnings
branch
from
1e8db7b to
20e9baa
Compare
This change gets rid of some GCC's -Wdeprecated-declarations warnings.
The conversions prevented return value optimization and caused a -Wreturn-std-move Clang warning.
This change gets rid of a few GCC's -Wdeprecated-declarations warnings.
Moving the initialization of defaultTexture out of the member initializer list gets rid of a GCC's -Wreorder warning. Initialize other texture pointers to improve safety and consistency.
vedgy
force-pushed
the
fix-some-compiler-warnings
branch
from
20e9baa to
629eb26
Compare
|
Split the |
2 participants
See the commit messages for details.