index/numPages/numSlides: unsigned => int#197
Open
vedgy wants to merge 1 commit intoYACReader:developfrom
Open
index/numPages/numSlides: unsigned => int#197vedgy wants to merge 1 commit intoYACReader:developfrom
vedgy wants to merge 1 commit intoYACReader:developfrom
Conversation
This change gets rid of a few GCC's -Wsign-compare warnings and several explicit casts because of different signedness. Make several getters const member functions rather than slots. Rename several signals from numPages() to numPagesChanged() to simplify using function pointer-based signal-slot connection syntax.
Contributor
Author
|
I've cleaned up |
luisangelsm
force-pushed
the
develop
branch
from
6ccfc51 to
63fcde8
Compare
luisangelsm
force-pushed
the
develop
branch
6 times, most recently
from
728e9bb to
2cd511f
Compare
luisangelsm
force-pushed
the
develop
branch
10 times, most recently
from
5d712af to
c2aa5f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change gets rid of a few GCC's -Wsign-compare warnings and several explicit casts because of different signedness.
Make several getters const member functions rather than slots.
Rename several signals from
numPages()tonumPagesChanged()to simplify using function pointer-based signal-slot connection syntax.