⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@blackWins
Copy link
Contributor

Description

Delete all *logs.txt files in current folder.

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

use abp clean-logs

@enisn enisn requested a review from yekalkan January 15, 2026 10:31

public static string GetShortDescription()
{
return "Delete all *logs.txt files in current folder.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is not clear. It says "in current folder" but implementation includes subfolders.

sb.AppendLine("Usage:");
sb.AppendLine(" abp clean-logs");
sb.AppendLine("");
sb.AppendLine("See the documentation for more info: https://abp.io/docs/latest/cli");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command should be documented as well.

}
Logger.LogInformation($"'Logs' files removed successfully!");

Logger.LogInformation("Logs cleaned successfully!");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger.LogInformation($"'Logs' files removed successfully!");
Logger.LogInformation("Logs cleaned successfully!");

It seems like a duplicate logging.

@yekalkan yekalkan requested a review from yagmurcelk January 16, 2026 05:58
@yekalkan yekalkan added this to the 10.2-preview milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants