fix: prevent crash over missing some env vars#157
Open
ivinjabraham wants to merge 1 commit intodevelopfrom
Open
fix: prevent crash over missing some env vars#157ivinjabraham wants to merge 1 commit intodevelopfrom
ivinjabraham wants to merge 1 commit intodevelopfrom
Conversation
Environment variables like "ROOT_SECRET" and "ROOT_PORT" can have sensible defaults and does not need to nag the user to set them in order to start. Provide default values in case they are not found in env. Additionally, the default provided for ROOT_ENV is passed in through `unwrap_or_else`, but this extra lazy evaluation isn't optimizing much and only hinders readability. Change this to `unwrap_or` as simple strings are not compute heavy enough to warrant the lazy eval. Signed-off-by: Ivin Joel Abraham <ivinjoelabraham@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment variables like "ROOT_SECRET" and "ROOT_PORT" can have sensible defaults and does not need to nag the user to set them in order to start. Provide default values in case they are not found in env.
Additionally, the default provided for ROOT_ENV is passed in through
unwrap_or_else, but this extra lazy evaluation isn't optimizing much and only hinders readability. Change this tounwrap_oras simple strings are not compute heavy enough to warrant the lazy eval.