This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Instantiate Tinymce event if id is generated with angular expression in ngRepeat#354
Open
stollr wants to merge 3 commits intoangular-ui:masterfrom
Open
Instantiate Tinymce event if id is generated with angular expression in ngRepeat#354stollr wants to merge 3 commits intoangular-ui:masterfrom
stollr wants to merge 3 commits intoangular-ui:masterfrom
Conversation
added 3 commits
February 23, 2018 14:37
… may be overwritten, if the id is generated with an angular expression, so we have to overwrite it again. Otherwise tinymce won't be initialized.
…orms that are already dirty (for dynamically added editors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For dynamically created editors (e.g. with ngRepeat) the unique id that is generated and set to the element during linking may be overwritten, if the id is generated with an angular expression, so we have to overwrite it again.
Otherwise tinymce won't be initialized.
Here's an example:
During linking of
uiTinymcetheidis set to something like"ui-tinymce-3". But then it replaced to something like"foo_2"and intinymce.init()it won't find the element, because it uses the selector"#ui-tinymce-3".