Move remaining event registrations to renderer #32640
Open
+94
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches over the tooltip's event registration to go through the renderer like the rest of the repo.
crisbeto
added
the
merge: preserve commits
Fixes an event in the chip row that wasn't registered through the renderer.
Switches the sidenav to bind the escape key listener through the renderer like the rest of the repo.
crisbeto
force-pushed
the
more-manual-events
branch
from
9c22b54 to
59ba07a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last year we went through the exercise of registering our events through the renderer so that some framework instrumentation can pick them up. These changes update some events that were done the last time around.