⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@damccorm
Copy link
Contributor

@damccorm damccorm commented Jan 16, 2026

See #35962 (comment) - we made a mistake moving this example off of setup_tools and instead should have just fixed the distutils problem.

To make this PR easy to review, I split it into 2 commits. The first one just reverts the change from #35962, the second makes the distutils fix

Testing this against https://github.com/apache/beam/actions/runs/21080349489 to make sure I'm not reintroducing the problem this PR was originally trying to solve.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @damccorm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request rectifies a prior decision by re-adopting setuptools for the JuliaSet example's dependency and packaging needs, moving away from a requirements.txt based approach. The change ensures that the example properly utilizes setup.py for building and distributing its components to Dataflow workers, which is a more robust and feature-rich method for managing Python project dependencies and installation within the Apache Beam ecosystem. This update streamlines the deployment process and aligns with best practices for Python Dataflow workflows.

Highlights

  • Dependency Management Migration: The JuliaSet example has been migrated from using a requirements.txt file for dependency management to a setup.py file, leveraging setuptools for packaging and distribution.
  • Reversal of Previous Change: This pull request explicitly undoes a previous change (PR Fix PostCommit Python Arm job #35962) that moved the example away from setuptools, acknowledging that the initial problem should have been fixed within the distutils context rather than abandoning setuptools.
  • Updated Example Configuration: The integration test (juliaset_test_it.py) and the main execution script (juliaset_main.py) have been updated to use the --setup_file option instead of --requirements_file when running the Dataflow pipeline, pointing to the newly introduced setup.py.
  • Introduction of setup.py with Custom Commands: A new setup.py file has been added for the JuliaSet example, which defines the package using setuptools. It also includes an example of custom build commands that can be executed during package installation on worker machines.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant