-
Notifications
You must be signed in to change notification settings - Fork 1.3k
disable deprecated plugins #12500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.22
Are you sure you want to change the base?
disable deprecated plugins #12500
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #12500 +/- ##
============================================
+ Coverage 17.59% 17.67% +0.07%
+ Complexity 15611 15609 -2
============================================
Files 5910 5884 -26
Lines 529890 527450 -2440
Branches 64737 64394 -343
============================================
- Hits 93259 93239 -20
+ Misses 426135 423716 -2419
+ Partials 10496 10495 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR disables the deprecated UCS and Hyper-V hypervisor plugins by removing them from the build configuration and cleaning up related constants and configurations.
Changes:
- Removed UCS and Hyper-V hypervisor plugin modules from the plugins build configuration
- Removed UCS and Hyper-V plugin dependencies from the client module
- Removed UCS-related configuration setting (UCSSyncBladeInterval) from server configuration
- Removed two UCS-related API constants (UCS_DN and UCS_MANAGER_ID)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/pom.xml | Removed hyperv and ucs hypervisor modules from the build |
| client/pom.xml | Removed cloud-plugin-hypervisor-ucs and cloud-plugin-hypervisor-hyperv dependencies |
| server/src/main/java/com/cloud/configuration/Config.java | Removed UCSSyncBladeInterval configuration enum entry |
| api/src/main/java/org/apache/cloudstack/api/ApiConstants.java | Removed UCS_DN and UCS_MANAGER_ID constants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public static final String UCS_PROFILE_DN = "profiledn"; | ||
| public static final String UCS_BLADE_DN = "bladedn"; | ||
| public static final String UCS_BLADE_ID = "bladeid"; |
Copilot
AI
Jan 22, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete removal of UCS-related constants. Since the UCS hypervisor plugin is being disabled, these remaining UCS constants (UCS_PROFILE_DN, UCS_BLADE_DN, UCS_BLADE_ID) should also be removed for consistency with the removal of UCS_DN and UCS_MANAGER_ID.
| public static final String UCS_PROFILE_DN = "profiledn"; | |
| public static final String UCS_BLADE_DN = "bladedn"; | |
| public static final String UCS_BLADE_ID = "bladeid"; |
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16502 |
| "Advanced", | ||
| ManagementServer.class, | ||
| Integer.class, | ||
| "ucs.sync.blade.interval", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we remove this from configuration table as well?



Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?