⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@DaanHoogland
Copy link
Contributor

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.67%. Comparing base (b1f870a) to head (5aea69f).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12500      +/-   ##
============================================
+ Coverage     17.59%   17.67%   +0.07%     
+ Complexity    15611    15609       -2     
============================================
  Files          5910     5884      -26     
  Lines        529890   527450    -2440     
  Branches      64737    64394     -343     
============================================
- Hits          93259    93239      -20     
+ Misses       426135   423716    -2419     
+ Partials      10496    10495       -1     
Flag Coverage Δ
uitests 3.60% <ø> (ø)
unittests 18.75% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables the deprecated UCS and Hyper-V hypervisor plugins by removing them from the build configuration and cleaning up related constants and configurations.

Changes:

  • Removed UCS and Hyper-V hypervisor plugin modules from the plugins build configuration
  • Removed UCS and Hyper-V plugin dependencies from the client module
  • Removed UCS-related configuration setting (UCSSyncBladeInterval) from server configuration
  • Removed two UCS-related API constants (UCS_DN and UCS_MANAGER_ID)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
plugins/pom.xml Removed hyperv and ucs hypervisor modules from the build
client/pom.xml Removed cloud-plugin-hypervisor-ucs and cloud-plugin-hypervisor-hyperv dependencies
server/src/main/java/com/cloud/configuration/Config.java Removed UCSSyncBladeInterval configuration enum entry
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java Removed UCS_DN and UCS_MANAGER_ID constants

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 1088 to 1090
public static final String UCS_PROFILE_DN = "profiledn";
public static final String UCS_BLADE_DN = "bladedn";
public static final String UCS_BLADE_ID = "bladeid";
Copy link

Copilot AI Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete removal of UCS-related constants. Since the UCS hypervisor plugin is being disabled, these remaining UCS constants (UCS_PROFILE_DN, UCS_BLADE_DN, UCS_BLADE_ID) should also be removed for consistency with the removal of UCS_DN and UCS_MANAGER_ID.

Suggested change
public static final String UCS_PROFILE_DN = "profiledn";
public static final String UCS_BLADE_DN = "bladedn";
public static final String UCS_BLADE_ID = "bladeid";

Copilot uses AI. Check for mistakes.
@apache apache deleted a comment from blueorangutan Jan 22, 2026
@apache apache deleted a comment from blueorangutan Jan 22, 2026
@apache apache deleted a comment from blueorangutan Jan 22, 2026
@sonarqubecloud
Copy link

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16502

"Advanced",
ManagementServer.class,
Integer.class,
"ucs.sync.blade.interval",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this from configuration table as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants