fix: reuse partition field IDs for equivalent fields in AddSpec #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @liurenjie1024 , could you please review this PR? Thanks! |
pratik0316
reviewed
Jan 13, 2026
| &self, | ||
| unbound_spec: UnboundPartitionSpec, | ||
| ) -> Result<UnboundPartitionSpec> { | ||
| use std::collections::HashMap; |
There was a problem hiding this comment.
can we have this import above (following convention in other places of file)
Contributor
Author
There was a problem hiding this comment.
I'm not even sure why I added this here, it's already imported at the top of this file. Updating PR to remove it.
aditya-subrahmanyan
force-pushed
the
adityasn/add-spec-partition-field-reuse
branch
from
db0ea04 to
e903576
Compare
Implements Iceberg spec requirement to reuse partition field IDs when adding specs with equivalent fields (same source_id + transform). - Add Hash trait to Transform enum for HashMap keys - Add field ID reuse logic in TableMetadataBuilder.add_partition_spec() - Add test for multi-spec field ID reuse scenarios
aditya-subrahmanyan
force-pushed
the
adityasn/add-spec-partition-field-reuse
branch
from
e903576 to
e3d2cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Implements Iceberg spec requirement to reuse partition field IDs when adding specs with equivalent fields (same source_id + transform).
Are these changes tested?
Added a test to cover partition field id reuse when new specs are added