JAMES-4164 Conciliate sender rewrites (~forwards) and vacation #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use record instead of unnamed pair - Avoid double computation of RecipientId, AccountId - Undo unneeded extract, but re-extract relevant portion of the code
jeantil
reviewed
Jan 15, 2026
Comment on lines
+7
to
+10
|
|
||
| The `replyMode` property determine how we compute the recipient of the vacation reply: | ||
| - `replyToHeader` (default mode) we lookup the `Reply-To` field of the incoming email | ||
| - `envelope` (legacy, here to enable backward behavioural compatibility) use the MAIL FROM of the original mail, which could |
server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/VacationMailet.java
Show resolved
Hide resolved
quantranhong1999
approved these changes
Jan 16, 2026
Arsnael
approved these changes
Jan 16, 2026
Contributor
Author
|
Hello Objections moving forward with this job? |
jeantil
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.