fix: handle sequence=0 during cluster shard failover#377
Open
Kaustubh1204 wants to merge 1 commit intoapache:unstablefrom
Open
fix: handle sequence=0 during cluster shard failover#377Kaustubh1204 wants to merge 1 commit intoapache:unstablefrom
Kaustubh1204 wants to merge 1 commit intoapache:unstablefrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Failover fails when a shard has never received any writes and its sequence number is
0.In this case, the validation logic incorrectly rejects the failover even when both the
current master and the new master have a sequence of
0.This scenario is reported in issue #366 and can occur for empty or newly created shards.
Solution
Update the failover validation logic to explicitly allow
sequence == 0when thecurrent master’s sequence is also
0.This ensures failover works correctly for empty shards without changing behavior
for non-zero sequence cases.
Scope
Testing
Fixes #366