cleanup: Remove securityManager use on startup#9109
Open
BradWalker wants to merge 1 commit intoapache:masterfrom
Open
cleanup: Remove securityManager use on startup#9109BradWalker wants to merge 1 commit intoapache:masterfrom
BradWalker wants to merge 1 commit intoapache:masterfrom
Conversation
desc: This change removes the use of securityManager on startup of netbeans. This is a fairly simple change but had far reaching impacts as it deals w/ startup. For this reason, I created this change just for this issue.
Member
JNLP is part of webstart/applets. So yes this code ( This means that the PR title and the commit message makes a somewhat misleading promise. It might be better to delay removal of this specific SM usage and remove the JNLP integration entirely later (without breaking it via small paper cuts). (although I believe its unlikely that anyone is still using this) Curious what others think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cleanup: Remove securityManager use on startup
desc: This change removes the use of securityManager on startup of netbeans. This is a fairly simple change but had far reaching impacts as it deals w/ startup. For this reason, I created this change just for this issue.
In addition, as I read the code,
netbeans.jnlp.fixPolicyis always false. Meaning thefixPolicy()will never execute.^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)