Fix FileNotFoundException handling in segment download API #17523
+84
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Jackie-Jiang @ankitsultana Requesting your help in running the above workflow and reviewing the changes |
Contributor
Jackie-Jiang
left a comment
Jackie-Jiang
left a comment
There was a problem hiding this comment.
Please fix the test failure
| private boolean isFileNotFoundException(Exception e) { | ||
| Throwable cause = e; | ||
| while (cause != null) { | ||
| if (cause instanceof java.io.FileNotFoundException) { |
| if (cause instanceof java.io.FileNotFoundException) { | ||
| return true; | ||
| } | ||
| cause = cause.getCause(); |
Contributor
There was a problem hiding this comment.
Could this potentially cause infinite loop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16231
When the /segments controller API encountered a FileNotFoundException, it exhibited below issues -
In this PR, I have implemented two improvements -
BaseSegmentFetcherto detect FileNotFoundException in the exception cause chain and fail immediately without retryingPinotSegmentUploadDownloadRestletResourceto catch FileNotFoundException and return Response.Status.NOT_FOUND instead of 500Unit Tests
✅ 4 new tests added to verify FileNotFoundException behaviour
✅ All existing tests pass - no breaking changes
bugfix