feat(helm): add pdb for minion and minion-stateless #17538
+102
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17538 +/- ##
============================================
- Coverage 63.21% 63.18% -0.03%
- Complexity 1476 1477 +1
============================================
Files 3170 3172 +2
Lines 189508 189773 +265
Branches 28997 29041 +44
============================================
+ Hits 119789 119908 +119
- Misses 60417 60557 +140
- Partials 9302 9308 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds PodDisruptionBudget (PDB) support for Pinot's minion and minion-stateless components to ensure minimum availability during voluntary disruptions, particularly useful for deployments on spot/preemptible VMs.
Changes:
- Added PDB configuration sections to
minionandminionStatelessin values.yaml - Created PDB template files for both minion components
- Disabled by default to maintain backward compatibility
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| helm/pinot/values.yaml | Added pdb configuration blocks for both minion components with enabled, minAvailable, and maxUnavailable fields |
| helm/pinot/templates/minion/poddisruptionbudget.yaml | New PDB template for minion component with conditional rendering based on configuration |
| helm/pinot/templates/minion-stateless/poddisruptionbudget.yaml | New PDB template for minion-stateless component with conditional rendering based on configuration |
PovilasV1
force-pushed
the
feat/add_minion_pdb
branch
2 times, most recently
from
ebdda3e to
6c347ce
Compare
PovilasV1
force-pushed
the
feat/add_minion_pdb
branch
from
6c347ce to
c6a3590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PodDisruptionBudget support for Minion components
Summary
Adds PDB configuration support for
minionandminionStatelesscomponents to match existing controller/broker/server functionality.Changes
pdbsection tominioninvalues.yamlpdbsection tominionStatelessinvalues.yamlUse Case
Ensures minimum minion availability during voluntary disruptions, especially useful when running on spot/preemptible VMs.