testclient: add regression test for LoadSimulationController executor… #25156
+98
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an executor thread leak in
LoadSimulationControllerand adds/updates tests to prevent regressions.Why is this needed?
LoadSimulationControllerpreviously used a cachedExecutorServicewithout a shutdown path, which can leave non-daemon threads running and delay or prevent clean JVM shutdown in embedded or containerized test environments.What changed?
AutoCloseableand added aclose()method that shuts down the executor safely.finallyinrun().close().How was this tested?
Updated JUnit 5 test creates a controller instance, forces executor thread creation, calls
close(), and verifies the executor threads terminate.Docs
docdoc-requireddoc-not-neededdoc-complete