⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jan 16, 2026

Fixes #25154

Motivation

While investigating a flaky test, I noticed that a Pulsar Function instance didn't shutdown gracefully due to interrupted thread status. The change in #25140 brought this to surface since closing producers gracefully requires that the calling thread isn't interrupted.

Modifications

Clear the interrupted state of the current thread in the Function instance before proceeding to call the close method.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Copy link
Contributor

@liangyepianzhou liangyepianzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.53%. Comparing base (413387b) to head (ab15c09).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #25157       +/-   ##
=============================================
+ Coverage     37.48%   72.53%   +35.05%     
- Complexity    13220    34226    +21006     
=============================================
  Files          1899     1956       +57     
  Lines        150586   154750     +4164     
  Branches      17159    17645      +486     
=============================================
+ Hits          56440   112241    +55801     
+ Misses        86464    33539    -52925     
- Partials       7682     8970     +1288     
Flag Coverage Δ
inttests 25.74% <0.00%> (+0.09%) ⬆️
systests 22.41% <100.00%> (-0.03%) ⬇️
unittests 73.47% <100.00%> (+39.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ulsar/functions/instance/JavaInstanceRunnable.java 73.17% <100.00%> (+12.14%) ⬆️

... and 1417 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lhotari lhotari merged commit 0bf560f into apache:master Jan 16, 2026
56 checks passed
lhotari added a commit that referenced this pull request Jan 16, 2026
… producers are closed (#25157)

(cherry picked from commit 0bf560f)
lhotari added a commit that referenced this pull request Jan 16, 2026
… producers are closed (#25157)

(cherry picked from commit 0bf560f)
lhotari added a commit that referenced this pull request Jan 16, 2026
… producers are closed (#25157)

(cherry picked from commit 0bf560f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky-test: PulsarFunctionE2ESecurityTest.testAuthorization

4 participants