fix(rpc): improve error reporting for socket path issues. #12799
+13
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace generic ENAMETOOLONG errno with an error that indicates the rpc socket issue. Also improve startup error message clarity.
Member
|
[approve ci] |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when you use autest, you could end up with a large socket pathname.
You only discover this once you try to access the jsonrpc node, but even when
you get an error, it's hard to identify the root cause.
With this change, you'll now find a clearer error in the logs that points you
in the right direction.
Replace generic
ENAMETOOLONGerrno with an error that indicates the RPCsocket issue. Also improve startup error message clarity.
Note: Using
fprintfas it seems the log machinery may not be fully initialized at this point.