⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@Piyushkhobragade
Copy link
Contributor

This PR fixes a documentation inconsistency in the metrics reference.

argocd_oci_request_duration_seconds is defined as a histogram and represents request latency, but the documentation previously described it as a failure count. Failure-related metrics already exist as *_fail_total.

This change updates the description to accurately reflect the metric semantics.

Fixes #25912

@Piyushkhobragade Piyushkhobragade requested review from a team as code owners January 10, 2026 02:27
@bunnyshell
Copy link

bunnyshell bot commented Jan 10, 2026

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@Piyushkhobragade
Copy link
Contributor Author

/dco

@blakepettersson
Copy link
Member

@Piyushkhobragade you need to do

git commit --amend -s && git push -f

@Piyushkhobragade Piyushkhobragade force-pushed the docs/fix-oci-metric-description branch from c02ffdf to a1f74b6 Compare January 10, 2026 16:29
@blakepettersson
Copy link
Member

Thanks!

@blakepettersson blakepettersson merged commit 5d790e5 into argoproj:master Jan 11, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Definition of metric argocd_oci_request_duration_seconds metric in argocd docs is misaligned

2 participants