Update _isnumber to ensure the output string convertible to float#252
Update _isnumber to ensure the output string convertible to float#252zhihanyue wants to merge 1 commit intoastanin:masterfrom
Conversation
|
While this PR may solve the issue with numpy.datetime64, it does not go far enough to also fix incorrect conversions of strings to float, e.g. Update: I discovered |
|
I argue in #351 that, if you have a type that converts both to int/float and to str, and you explicitly prefer the str representation -- that you should either:
Otherwise, the (much more common) situation -- where you tabulate types that are convertible to int/float -- would be greatly interfered with by a change such as this. Ah; as you found |
|
This PR needs test cases to cover and document all new edge cases, and how they are now handled. |
The numpy.datetime64[ns] was recognized as float, because numpy.datetime64[ns] is convertible to float. This PR fixes this problem.
Fix #251