⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR adds an integration test case for the Batch Processing utility, which was not previously covered. The test purposefully includes only one test case with standard SQS queue since the main goal of the test is to verify that the utility works in Lambda together with Parser, rather than covering the entire spectrum of features of the utility, which rely on similar implementations anyway.

To create this test I had to implement a new utility function that tails CloudWatch logs since this is also the first test that we add that can't be observed by querying logs or by collecting the response of a specific function invocation. This is due to the fact that we only publish messages to a SQS queue and we don't control how many or when the function invocations will happen.

This new testing utility lives under the packages/testing package and handles the tailing of a CloudWatch Log Group, collects the logs, and stops tailing after a given idle time.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #4489


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Jan 28, 2026
@dreamorosi dreamorosi linked an issue Jan 28, 2026 that may be closed by this pull request
2 tasks
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Jan 28, 2026
@boring-cyborg boring-cyborg bot added automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. tests PRs that add or change tests labels Jan 28, 2026
@dreamorosi
Copy link
Contributor Author

Integration tests - including the new ones - are green.

@dreamorosi dreamorosi force-pushed the 4489-maintenance-add-e2e-tests-for-batch-processing branch from 18a0bd0 to 267412c Compare January 29, 2026 17:19
@dreamorosi
Copy link
Contributor Author

Thanks for the review @svozza - good shouts on the simplification, I think I addressed most/all of them, let me know if this is what you had in mind.

@dreamorosi dreamorosi requested a review from svozza January 29, 2026 17:20
@sonarqubecloud
Copy link

@svozza
Copy link
Contributor

svozza commented Jan 29, 2026

Thanks for the review @svozza - good shouts on the simplification, I think I addressed most/all of them, let me know if this is what you had in mind.

One tiny comment but other than that LGTM.

@dreamorosi dreamorosi merged commit 180a9d1 into main Jan 29, 2026
51 checks passed
@dreamorosi dreamorosi deleted the 4489-maintenance-add-e2e-tests-for-batch-processing branch January 29, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. size/XL PRs between 500-999 LOC, often PRs that grown with feedback tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: add e2e tests for Batch Processing

2 participants