-
Notifications
You must be signed in to change notification settings - Fork 187
test: add e2e tests for batch processing #4978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add e2e tests for batch processing #4978
Conversation
|
Integration tests - including the new ones - are green. |
18a0bd0 to
267412c
Compare
|
Thanks for the review @svozza - good shouts on the simplification, I think I addressed most/all of them, let me know if this is what you had in mind. |
|
One tiny comment but other than that LGTM. |



Summary
Changes
This PR adds an integration test case for the Batch Processing utility, which was not previously covered. The test purposefully includes only one test case with standard SQS queue since the main goal of the test is to verify that the utility works in Lambda together with Parser, rather than covering the entire spectrum of features of the utility, which rely on similar implementations anyway.
To create this test I had to implement a new utility function that tails CloudWatch logs since this is also the first test that we add that can't be observed by querying logs or by collecting the response of a specific function invocation. This is due to the fact that we only publish messages to a SQS queue and we don't control how many or when the function invocations will happen.
This new testing utility lives under the packages/testing package and handles the tailing of a CloudWatch Log Group, collects the logs, and stops tailing after a given idle time.
Issue number: closes #4489
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.