Merged
Conversation
…test for S3 events
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
=======================================
Coverage 74.94% 74.94%
=======================================
Files 36 36
Lines 1401 1401
=======================================
Hits 1050 1050
Misses 273 273
Partials 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
darklight3it
requested changes
Jan 30, 2026
Contributor
darklight3it
left a comment
There was a problem hiding this comment.
Please make the tests run
9787104 to
a66ce2d
Compare
Contributor
Author
|
@darklight3it Thanks for the review! The test job failed due to a flaky test. I don't have permission to re-run jobs, so I pushed an amended commit (no code changes) to trigger a re-run. I've confirmed all test jobs are now passing. |
darklight3it
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#611
Description of changes:
The S3 event has some optional fields defined in the AWS documentation, but the existing S3 event struct doesn't include them. This PR adds the following fields.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.