⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Add S3 event optional fields#612

Merged
darklight3it merged 6 commits intoaws:mainfrom
yhamano0312:feat/add-s3-event-fields
Feb 6, 2026
Merged

Add S3 event optional fields#612
darklight3it merged 6 commits intoaws:mainfrom
yhamano0312:feat/add-s3-event-fields

Conversation

@yhamano0312
Copy link
Contributor

@yhamano0312 yhamano0312 commented Dec 23, 2025

Issue #, if available:
#611

Description of changes:
The S3 event has some optional fields defined in the AWS documentation, but the existing S3 event struct doesn't include them. This PR adds the following fields.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.94%. Comparing base (9dac8a5) to head (a66ce2d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   74.94%   74.94%           
=======================================
  Files          36       36           
  Lines        1401     1401           
=======================================
  Hits         1050     1050           
  Misses        273      273           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yhamano0312 yhamano0312 marked this pull request as ready for review December 24, 2025 02:25
@darklight3it darklight3it self-requested a review January 30, 2026 15:10
Copy link
Contributor

@darklight3it darklight3it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@darklight3it darklight3it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the tests run

@yhamano0312 yhamano0312 force-pushed the feat/add-s3-event-fields branch from 9787104 to a66ce2d Compare February 6, 2026 05:46
@yhamano0312
Copy link
Contributor Author

@darklight3it Thanks for the review! The test job failed due to a flaky test. I don't have permission to re-run jobs, so I pushed an amended commit (no code changes) to trigger a re-run. I've confirmed all test jobs are now passing.

@darklight3it darklight3it merged commit e1cb461 into aws:main Feb 6, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants