feat(memory): update session manager for Strands integration #170

akshseh · 2025-11-24T15:30:59Z

Issue #, if available: #149

Description of changes: Update Agentcore SessionManager for strands to use branching and metadata features of AgentCore Memory.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

afarntrog · 2025-11-24T22:48:17Z

src/bedrock_agentcore/memory/integrations/strands/config.py

+class ShortTermRetrievalConfig(BaseModel):
+    """Configuration for Short term memory retrieval operations"""
+
+    branch_filter: Optional[bool] = True


Is there a plan to have branching on LTM? We can refactor later but then we should consider lifting the branch_filter into a base class

yes there is.

afarntrog · 2025-11-24T22:50:47Z

src/bedrock_agentcore/memory/integrations/strands/config.py

+    default_branch: Optional[BranchConfig] = Field(
+        default_factory=lambda: BranchConfig(name="main", root_event_id="")
+    )
+    short_term_retrieval_config: Optional[ShortTermRetrievalConfig] = (


does this needs it's own variable? Can we allow for this to be set to the retrieval_config? Or do we anticipate users passing in both STM and LTM config for the same session?

afarntrog · 2025-11-24T22:53:46Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

+            if self.config.metadata:
+                metadata.update(self.config.metadata)
+
+            if branch_name == "main":


since this is a special case let's make it a constant at the top

afarntrog · 2025-11-24T22:54:57Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

+                created_event = self.memory_session_manager.create_event(**event_params)
+            else:
+                created_event = self.memory_session_manager.fork_conversation(
+                    actor_id=self.config.actor_id,


is it necessary to pass in all these self parameters? This method signature is very bulky. Let's use the self data from inside that fork_conversation method

afarntrog · 2025-11-24T23:00:47Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

+    def create_session(self, session: Session, **kwargs: Any) -> Session:
+        """Create a new session."""
+        self._validate_session_id(session.session_id)
+        return session



where in agentcore is the session data stored?

afarntrog · 2025-11-24T23:05:23Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

+            if payload and "blob" in payload[0]:
+                blob_data = json.loads(payload[0]["blob"])
+                # Extract SessionAgent from blob.
+                session_data = blob_data.get("session_state") or blob_data.get(


what's with this or here? are we storing it either as a session_state or a session object?

will remove session

afarntrog · 2025-11-24T23:08:27Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

+                if role in self.config.message_types:
+                    content = message.get("content", [{}])[0].get("text", "")
+                    mapped_role = role_map.get(role, MessageRole.ASSISTANT)
+                    if role == "user":


we can use the mapped_role here

afarntrog · 2025-11-24T23:11:49Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

            registry (HookRegistry): The hook registry to register callbacks with.
            **kwargs: Additional keyword arguments.
        """
-        RepositorySessionManager.register_hooks(self, registry, **kwargs)


just to be clear, this line removes all the hooks that are expected as part of the session management approach in strands

yes, I think it should override those. We don't need the parent hooks alongside these for Session Management.

afarntrog · 2025-11-24T23:13:20Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

+                messages[-1]["content"][0][
+                    "text"
+                ] = f"<previous_context>\n{context_text}\n</previous_context>\n\n{original_text}\n"
+                event.agent.messages[-1]["content"][0]["text"] = context_text


what's the intent behind this why we are modifying the message directly? This will not get saved to LTM as the message added hook will not be triggered. Is this the expected behavior?

afarntrog · 2025-11-25T15:26:58Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

        except Exception as e:
            logger.error("Failed to list messages from AgentCore Memory: %s", e)


I'm starting to see this error come up each time I initialize an agent now. Here is my code:

import uuid import boto3 from datetime import date, datetime from strands import Agent from bedrock_agentcore.memory import MemoryClient from bedrock_agentcore.memory.integrations.strands.config import AgentCoreMemoryConfig, RetrievalConfig from bedrock_agentcore.memory.integrations.strands.session_manager import AgentCoreMemorySessionManager MEM_ID = 'BasicTestMemory20251103223555-Mowu0s9pwM' ACTOR_ID = "actor_id_test_%s" % datetime.now().strftime("%Y%m%d%H%M%S") SESSION_ID = "testing_session_id_%s" % datetime.now().strftime("%Y%m%d%H%M%S") config = AgentCoreMemoryConfig( memory_id=MEM_ID, session_id=SESSION_ID, actor_id=ACTOR_ID ) stm_session_manager = AgentCoreMemorySessionManager(config, region_name='us-east-1') stm_agent_1 = Agent(session_manager=stm_session_manager)

then

stm_agent_1("hello")

I see Failed to retrieve customer context: 'NoneType' object has no attribute 'items' printed out.

And then if I now initialize another agent with the same session manager I see:

stm_agent_2 = Agent(session_manager=stm_session_manager)

Failed to list messages from AgentCore Memory: Expecting value: line 1 column 1 (char 0)

yes fix added to check empty events

…dk-python

jariy17 · 2026-01-29T22:41:36Z

src/bedrock_agentcore/memory/integrations/strands/config.py

+    short_term_retrieval_config: Optional[ShortTermRetrievalConfig] = (
+        ShortTermRetrievalConfig()
+    )
+    message_types: Optional[List[str]] = Field(default=["user", "assistant"])


we to emphasize its agentcore message_types ("user", "assistant", "toolResult", "other"). *check if this filter issues. add to default "other", "tool_use".

jariy17 · 2026-01-29T22:52:02Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

            logger.error("Failed to retrieve customer context: %s", e)

    @override
    def register_hooks(self, registry: HookRegistry, **kwargs) -> None:


This PR got rid of session because

if you want to support multiple agents, agentcore memory can only handle one session per agent.

jariy17 · 2026-01-29T22:53:41Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

+            boto3_session=boto_session,
+            boto_client_config=boto_client_config,
+        )
+        self.agent_id = None


THIS PR has no idea how to use agent_id. Research what agent_id used for strands.

jariy17 · 2026-01-29T22:57:06Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

-        self._latest_agent_message[agent.agent_id] = session_message
+            # Load previous messages
+            prev_messages = self.list_messages(
+                self.config.session_id, agent.agent_id, limit=10


check if this breaks the current behavior, where we only store 10.

jariy17 · 2026-01-29T22:59:04Z

src/bedrock_agentcore/memory/integrations/strands/session_manager.py

-                logger.info("Retrieved %s customer context items", len(all_context))
+                messages[-1]["content"][0][
+                    "text"
+                ] = f"<previous_context>\n{context_text}\n</previous_context>\n\n{original_text}\n"


This should still show the issue where the model will focus the user stuff.

jariy17 · 2026-01-29T23:09:51Z

src/bedrock_agentcore/memory/integrations/strands/config.py

+    """Configuration for Short term memory retrieval operations"""
+
+    branch_filter: Optional[bool] = True
+    metadata: Optional[Dict[str, StringValue]] = None


This is how you would filter by agent_id. Use to get a agent's memory

this is currently supportly supported.
This should be named additional_metadata_fields.

Customers don't really need metadata filtering just keep agent_id.

jariy17 · 2026-01-29T23:11:01Z

src/bedrock_agentcore/memory/integrations/strands/config.py

+    )
+    message_types: Optional[List[str]] = Field(default=["user", "assistant"])
+    metadata: Optional[Dict[str, StringValue]] = (
+        None  # Currently only supports agent_id. Will be extended further.


the comment is lie. it allow customer's metada.

feat(memory): update session manager.

7f76f2c

akshseh temporarily deployed to manual-approval November 24, 2025 15:31 — with GitHub Actions Inactive

afarntrog reviewed Nov 25, 2025

View reviewed changes

fix(session_manager): update session_manager

58ed5f7

akshseh temporarily deployed to manual-approval November 26, 2025 19:39 — with GitHub Actions Inactive

Merge branch 'aws:main' into main

40f319c

akshseh temporarily deployed to manual-approval November 28, 2025 17:16 — with GitHub Actions Inactive

akshseh added 2 commits November 28, 2025 15:12

feat(session_manager): update create_session functionality

ec7eea3

Merge branch 'main' of https://github.com/akshseh/bedrock-agentcore-s…

dcba595

…dk-python

akshseh temporarily deployed to manual-approval November 28, 2025 20:14 — with GitHub Actions Inactive

Merge branch 'aws:main' into main

7a8906b

akshseh temporarily deployed to manual-approval January 8, 2026 18:55 — with GitHub Actions Inactive

fix(session_manager): fix minor issues

b1115da

akshseh temporarily deployed to manual-approval January 8, 2026 21:03 — with GitHub Actions Inactive

jariy17 reviewed Jan 29, 2026

View reviewed changes

		except Exception as e:
		logger.error("Failed to list messages from AgentCore Memory: %s", e)

feat(memory): update session manager for Strands integration #170

Are you sure you want to change the base?

feat(memory): update session manager for Strands integration #170

Conversation

akshseh commented Nov 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants