⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 13, 2026

I think importing from individual crates is better than importing from reth and really seems to have a positive impact on compilation times and editor features. Anecdotally, editing the project seems much faster.

Ran just build after a cargo clean before and after

With barrel imports

$ time just build
    Finished `release` profile [optimized] target(s) in 2m 37s
    
real    2m37.869s
user    48m44.659s
sys     5m29.438s

Without barrel imports

$ time just build
    Finished `release` profile [optimized] target(s) in 2m 07s

real    2m7.848s
user    39m32.286s
sys     4m29.309s

(roughly 20% faster with these changes)

@meyer9 meyer9 force-pushed the meyer9/remove-reth-barrel-imports branch 2 times, most recently from 382e1ad to b2bb9c7 Compare January 13, 2026 02:13
@meyer9 meyer9 changed the base branch from meyer9/v1.10.0 to main January 13, 2026 02:13
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 13, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@meyer9 meyer9 force-pushed the meyer9/remove-reth-barrel-imports branch 2 times, most recently from a4886b7 to 8fadcf8 Compare January 13, 2026 02:15
@meyer9 meyer9 marked this pull request as ready for review January 13, 2026 02:15
@meyer9 meyer9 enabled auto-merge January 13, 2026 02:15
@meyer9 meyer9 force-pushed the meyer9/remove-reth-barrel-imports branch from 8fadcf8 to 5c1a66b Compare January 13, 2026 02:16
@meyer9 meyer9 requested review from danyalprout and refcell January 13, 2026 02:16
danyalprout
danyalprout previously approved these changes Jan 13, 2026
Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Faster build times is much appreciated. Would like @refcell to have a sanity check.

As a follow up would be great to add the root reth crate to cargo deny or something

@meyer9 meyer9 force-pushed the meyer9/remove-reth-barrel-imports branch from 5c1a66b to e7721f4 Compare January 13, 2026 02:36
@meyer9 meyer9 disabled auto-merge January 13, 2026 02:36
@meyer9 meyer9 force-pushed the meyer9/remove-reth-barrel-imports branch from e7721f4 to 237a7ef Compare January 13, 2026 02:42
@meyer9 meyer9 force-pushed the meyer9/remove-reth-barrel-imports branch from 237a7ef to 341e613 Compare January 13, 2026 02:51
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@meyer9 meyer9 added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 9fb0bc0 Jan 13, 2026
27 checks passed
@meyer9 meyer9 deleted the meyer9/remove-reth-barrel-imports branch January 13, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants