⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@meyer9
Copy link
Contributor

@meyer9 meyer9 commented Jan 13, 2026

Adds a cargo deny lint and config to deny importing reth directly.

@meyer9 meyer9 force-pushed the meyer9/cargo-deny-root-reth branch from b1b8d46 to 4204657 Compare January 13, 2026 02:50
@meyer9 meyer9 force-pushed the meyer9/remove-reth-barrel-imports branch from 237a7ef to 341e613 Compare January 13, 2026 02:51
@meyer9 meyer9 force-pushed the meyer9/cargo-deny-root-reth branch from 4204657 to 1b5d3cf Compare January 13, 2026 02:51
Base automatically changed from meyer9/remove-reth-barrel-imports to main January 13, 2026 03:23
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 13, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@meyer9 meyer9 force-pushed the meyer9/cargo-deny-root-reth branch from 1b5d3cf to a7a33ee Compare January 13, 2026 03:24
@meyer9 meyer9 marked this pull request as ready for review January 13, 2026 03:24
@@ -0,0 +1,3 @@
[bans]
deny = ["reth"]
multiple-versions = "allow" No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a follow up issue to set this to deny #409

@danyalprout danyalprout added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit 1c4d89e Jan 13, 2026
29 checks passed
@danyalprout danyalprout deleted the meyer9/cargo-deny-root-reth branch January 13, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants