⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Add Basenames Unit Tests #2893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arjun-dureja wants to merge 113 commits into
base: master
Choose a base branch
from
Open

Add Basenames Unit Tests #2893

arjun-dureja wants to merge 113 commits into from
+35,521 −116

Conversation

@arjun-dureja
Copy link
Collaborator

@arjun-dureja arjun-dureja commented Jan 10, 2026 •
edited
Loading

What changed? Why?

  • Added unit tests for the Basenames app - generated using Claude code

    • Added 103 test files with 2,036 unit tests
    • Achieved ~92% test code coverage
    • All tests pass lint, typecheck, and CI checks

  • Only test files have been changed, no existing functionality was modified

  • The testing library package was bumped for compatibility reasons

image

Have you tested the following pages?

BaseWeb

  • base.org
  • base.org/names
  • base.org/builders
  • base.org/ecosystem
  • base.org/name/jesse
  • base.org/manage-names
  • base.org/resources

@arjun-dureja
Add layout.test.tsx
ca65a00
@arjun-dureja
Add tests for app/(basenames)/names/page.tsx
5de938b
@arjun-dureja
Add tests for app/(basenames)/names/RegistrationProviders.tsx
65d34fb
@arjun-dureja
Add tests for app/(basenames)/manage-names/page.tsx
c601f11
@arjun-dureja
Add tests for app/(basenames)/name/not-found/page.tsx
514fa88
@arjun-dureja
Add tests for app/(basenames)/name/[username]/page.tsx
849d683
@arjun-dureja
Add tests for app/(basenames)/name/[username]/renew/page.tsx
ea3cb7e
@arjun-dureja
Add tests for app/(basenames)/name/[username]/ProfileProviders.tsx
bae37be
@arjun-dureja
Add tests for app/(basenames)/name/[username]/opengraph-image.tsx
e5c119e
@arjun-dureja
Add tests for app/(basenames)/api/basenames/[name]/assets/cardImage.s…
e373c0d 
…vg/route.tsx
@arjun-dureja
Add tests for app/(basenames)/api/basenames/getUsernames/route.ts
f1f6dbd
@arjun-dureja
Add tests for app/(basenames)/api/basenames/contract-uri/route.ts
7515683
@arjun-dureja
Add tests for app/(basenames)/api/basenames/contract-uri.json/route.ts
b307670
@arjun-dureja
Add tests for app/(basenames)/api/basenames/metadata/[tokenId]/route.ts
626b818
@arjun-dureja
Add tests for app/(basenames)/api/basenames/talentprotocol/[address]/…
ecc28e3 
…route.ts
@arjun-dureja
Add tests for app/(basenames)/api/basenames/avatar/ipfsUpload/route.ts
713218a
@arjun-dureja
Add tests for app/(basenames)/api/proofs/discountCode/route.ts
f18321a
@arjun-dureja
Add tests for app/(basenames)/api/proofs/discountCode/consume/route.ts
59ac80b
@arjun-dureja
Add tests for app/(basenames)/api/proofs/cb1/route.ts
824cdda
@arjun-dureja
Add tests for app/(basenames)/api/proofs/cbid/route.ts
da1d01b
@arjun-dureja
Add tests for app/(basenames)/api/proofs/bns/route.ts
4f57d62
@arjun-dureja
Add tests for app/(basenames)/api/proofs/coinbase/route.ts
d6d53e2
@arjun-dureja
Add tests for app/(basenames)/api/proofs/baseEthHolders/route.ts
a823f16
@arjun-dureja
Add tests for app/(basenames)/api/proxy/route.ts
9c8c66c
@arjun-dureja
Add tests for src/utils/basenames/getChain.ts
e229182
@arjun-dureja
Add tests for src/utils/basenames/getDomain.ts
3875508
@arjun-dureja
Add tests for src/utils/frames/basenames.ts
6bdc7a4
@arjun-dureja
Add tests for src/hooks/useBasenameChain.ts
d50d374
@arjun-dureja
Add tests for src/hooks/useBasenameExpirationBanner.tsx
f8ed96e
@arjun-dureja
Add tests for src/hooks/useBasenameResolver.ts
1e58a74
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 10, 2026 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Jan 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
base-web Ready Ready Preview, Comment Jan 12, 2026 1:11am

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2026
View reviewed changes
@arjun-dureja arjun-dureja changed the title Arjun/basenames unit tests Add Basenames Unit Tests Jan 16, 2026
@arjun-dureja arjun-dureja marked this pull request as ready for review January 16, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arjun-dureja @cb-heimdall