Optional op_return output for generate_and_send_coins#143
Open
jachiang wants to merge 3 commits intobitcoinops:masterfrom
Open
Optional op_return output for generate_and_send_coins#143jachiang wants to merge 3 commits intobitcoinops:masterfrom
jachiang wants to merge 3 commits intobitcoinops:masterfrom
Conversation
Previous change added a witness stack argument to the CTxInWitness initializer. However, methods such as CTransaction.deserialize() will initialize CTxInWitness() without a witness stack argument. This fix makes the witness stack argument optional.
elichai
approved these changes
Jan 16, 2020
Collaborator
elichai
left a comment
elichai
left a comment
There was a problem hiding this comment.
Don't understand the usecase but the technicality looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to conveniently generate
op_returnoutputs withgenerate_and_send_coins:This would be useful for taptweak chapter mini case-study: #132
datakeyword togenerate_and_send_coins:datais set, an additionalop_return(data)output will be created in the transaction at idx 1